linux-kernel - Re: [PATCH for mmotm 0414] vmscan,memcg: reintroduce sc->may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f11576a0904190434y1f897a57qeb22e478dd4d43bd@mail.gmail.com>
Date:	Sun, 19 Apr 2009 20:34:08 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH for mmotm 0414] vmscan,memcg: reintroduce sc->may_swap

2009/4/19 KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>:
> Hi
>
> Hi
>
>>> @@ -1724,6 +1728,7 @@ unsigned long try_to_free_mem_cgroup_pag
>>>       struct scan_control sc = {
>>>               .may_writepage = !laptop_mode,
>>>               .may_unmap = 1,
>>> +             .may_swap = 1,
>>>               .swap_cluster_max = SWAP_CLUSTER_MAX,
>>>               .swappiness = swappiness,
>>>               .order = 0,
>>> @@ -1734,7 +1739,7 @@ unsigned long try_to_free_mem_cgroup_pag
>>>       struct zonelist *zonelist;
>>>
>>>       if (noswap)
>>> -             sc.may_unmap = 0;
>>> +             sc.may_swap = 0;
>>
>> Can this be directly initialized?
>>
>> struct scan_control sc = {
>>        ...
>>        .may_swap = !noswap,
>>        ...
>> };
>
> your proposal is better coding style. but I also prefer condig style
> consistency.
> I think we should change may_unmap and may_swap at the same time.
> Thus, I'd like to does it by another patch.

Grr, I've misunderstood your comment.
Will fix as your suggestion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/