linux-kernel - Re: [PATCH 29/30] microblaze_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904271442.24870.arnd@arndb.de>
Date:	Mon, 27 Apr 2009 14:42:24 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...str.eu
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, john.williams@...alogix.com
Subject: Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

On Monday 27 April 2009, Michal Simek wrote:
> >       long            st_size;        /* Size of file, in bytes.  */
> 
> Maybe unsigned? Make more sense to me that file size is not minus.
> And for some types below.

st_size represents an off_t in user space, which is signed.
Just over half the existing architectures use signed types
for st_size, but for this (like Sam's suggestion for __u64),
I don't think it matters either way.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/