[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49F5A8AB.4040707@monstr.eu>
Date: Mon, 27 Apr 2009 14:44:27 +0200
From: Michal Simek <monstr@...str.eu>
To: Arnd Bergmann <arnd@...db.de>
CC: Christoph Hellwig <hch@...radead.org>,
linux-kernel@...r.kernel.org, john.williams@...alogix.com
Subject: Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update
Arnd Bergmann wrote:
> On Monday 27 April 2009, Michal Simek wrote:
>>> long st_size; /* Size of file, in bytes. */
>> Maybe unsigned? Make more sense to me that file size is not minus.
>> And for some types below.
>
> st_size represents an off_t in user space, which is signed.
> Just over half the existing architectures use signed types
> for st_size, but for this (like Sam's suggestion for __u64),
> I don't think it matters either way.
OK. Is it mean that your structure is perfect? If yes, I'll recompile toolchain and do some more tests.
Michal
>
> Arnd <><
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists