linux-kernel - Re: [patch] tracing/mm: add page frame snapshot trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090509102254.GA15245@elte.hu>
Date:	Sat, 9 May 2009 12:22:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Frédéric Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Andi Kleen <andi@...stfloor.org>,
	Matt Mackall <mpm@...enic.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [patch] tracing/mm: add page frame snapshot trace


* Wu Fengguang <fengguang.wu@...el.com> wrote:

> > How about changing it from 'trigger' to 'dump_range':
> 
> That's a better name!
> 
> >    echo "*" > /debug/tracing/objects/mm/pages/dump_range
> > 
> > being a shortcut for 'dump all'?
> 
> No I'm not complaining about -1. That's even better than "*",
> because the latter can easily be expanded by shell ;)
> 
> > And:
> > 
> >    echo "1000 2000" > /debug/tracing/objects/mm/pages/dump_range
> > 
> > ?
> 
> Now it's much more intuitive!
> 
> > The '1000' is the offset where the dumping starts, and 2000 is the 
> > size of the dump.
> 
> Ah the second parameter 2000 can easily be taken as "end"..

Ok ... i've changed the name to dump_range and added your fix for 
mapcount as well. I pushed it all out to -tip.

Would you be interested in having a look at that and tweaking the 
dump_range API to any variant of your liking, and sending a patch 
for that? Both "<start> <end>" and "<start> <size>" (or any other 
variant) would be fine IMHO.

The lseek hack is nice (and we can keep that) but an explicit range 
API would be nice, we try to keep all of ftrace scriptable.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/