linux-kernel - Re: [PATCH 2/2] Perform check in iov_iter_fault_in_readable() by check_readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hbzmd1g6.wl%vmayatsk@redhat.com>
Date:	Fri, 15 May 2009 13:56:25 +0200
From:	Vitaly Mayatskikh <v.mayatskih@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Vitaly Mayatskikh <v.mayatskih@...il.com>,
	Josef Bacik <josef@...hat.com>, sandeen@...hat.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Perform check in iov_iter_fault_in_readable() by check_readable_bytes()

At Fri, 15 May 2009 11:38:38 +0200, Andi Kleen wrote:
 
> Is that really something that users rely on? It looks like a seriously
> broken user program. Which one is that? (just that I can avoid it :)

IIRC, it was first noticed in some sanity test from ltp suite ;)

I'm readiny POSIX spec for write() once again:

http://www.opengroup.org/onlinepubs/9699919799/functions/write.html

"The write() function shall attempt to write nbyte bytes from the
buffer pointed to by buf to the file associated with the open file
descriptor, fildes."

Well, "shall attempt"... It's not clear to me, is it enough just to
validate user's buffer and gave up with error, like we do now?

-- 
wbr, Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/