linux-kernel - Re: [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Jul 2009 16:13:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Subrata Modak <subrata@...ux.vnet.ibm.com>
Cc:	linux-laptop@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...hat.com>,
	David Howells <dhowells@...hat.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/06] Fix compilation warning for
	arch/x86/kernel/apm_32.c


* Subrata Modak <subrata@...ux.vnet.ibm.com> wrote:

> Following fix is inspired by David Howells fix few days back:
> http://lkml.org/lkml/2009/7/9/109,
> 
> Signed-off-by: Subrata Modak<subrata@...ux.vnet.ibm.com>,
> ---
> 
> --- a/arch/x86/kernel/apm_32.c	2009-06-15 07:50:51.000000000 +0530
> +++ b/arch/x86/kernel/apm_32.c	2009-07-15 06:43:59.000000000 +0530
> @@ -811,7 +811,7 @@ static int apm_do_idle(void)
>  	u8 ret = 0;
>  	int idled = 0;
>  	int polling;
> -	int err;
> +	int uninitialized_var(err);

Please dont use uninitialized_var() as it's dangerous - in something 
as performance-uncritical as this we should initialize it to 0 and 
mention it in the changelog that this works around a GCC false 
positive warning.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/