linux-kernel - Re: [PATCH 18/16] implement posix O_SYNC and O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252615415.8722.150.camel@heimdal.trondhjem.org>
Date:	Thu, 10 Sep 2009 16:43:35 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Christoph Hellwig <hch@....de>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, akpm@...ux-foundation.org,
	drepper@...hat.com, viro@...iv.linux.org.uk, kyle@...artin.ca
Subject: Re: [PATCH 18/16] implement posix O_SYNC and O_DSYNC semantics

On Thu, 2009-09-10 at 22:40 +0200, Christoph Hellwig wrote:
> On Thu, Sep 10, 2009 at 04:38:40PM -0400, Trond Myklebust wrote:
> > >  	return vfs_fsync_range(file, file->f_path.dentry, pos,
> > > -			       pos + count - 1, 1);
> > > +			       pos + count - 1,
> > > +			       (file->f_flags & O_SYNC) ? 1 : 0);
> > >  }
> > >  EXPORT_SYMBOL(generic_write_sync);
> > >  
> > Shouldn't this be testing for
> > 
> >    file->f_flags & __O_SYNC
> > 
> > ?
> 
> Doesn't matter, we check early in the open path that __O_SYNC is only
> set together with O_SYNC.

Right, but (file->f_flags & O_SYNC) will be non-zero even if only the
O_DSYNC flag is set.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/