lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20091012.234214.110950674.davem@davemloft.net>
Date:	Mon, 12 Oct 2009 23:42:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rakib.mullick@...il.com
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org, zbr@...emap.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] connector: Passing required parameter for function
 cn_add_callback.

From: Rakib Mullick <rakib.mullick@...il.com>
Date: Tue, 13 Oct 2009 11:27:49 +0600

> On 10/12/09, David Miller <davem@...emloft.net> wrote:
>> From: Rakib Mullick <rakib.mullick@...il.com>
>>  Date: Mon, 12 Oct 2009 08:44:33 +0600
>>
>>
>>  >   */
>>  > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
>>  > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
>>  > netlink_skb_parms *nsp)
>>
>>
>> Your patches are unusable because your email client corrupts the
>>  patch, here you can see it is splitting up long lines.
>>
>>  Please fix this up and resubmit.
> Oops..... sorry for that. This is the second time I'm facing this
> problem. I'll try to fix it.
> I'm resubmitting the patch. Here I've recreate the patch to split the
> line into two.
> And it just reaches its 80 line mark. Hopefully it will be okay.

Upstream and my net-next-2.6 tree both have this function with
the proper parameters, maybe Andrew's -mm tree had some conflicts
and they weren't dealt with correctly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ