linux-kernel - Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1258273714.21668.13.camel@Joe-Laptop.home>
Date:	Sun, 15 Nov 2009 00:28:34 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Am??rico Wang <xiyou.wangcong@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
 &proc_dointvec,

On Sun, 2009-11-15 at 09:11 +0100, Ingo Molnar wrote:
> * Am??rico Wang <xiyou.wangcong@...il.com> wrote:
> > On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
> > >Seems to be a typo.
> > Acked-by: WANG Cong <xiyou.wangcong@...il.com>
> (Cc:-ed Eric who is running the sysctl tree these days)
> Almost everywhere in the kernel we use the shorter version, so all of 
> sysctl.c should eventually change to that variant.

It's closer to 50/50, but it's 1 vs 133 in that file.

$ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*&\s*\w+' * | wc -l
339

$ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*[^&]\s*\w+' * | wc -l
432


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/