linux-kernel - Re: [PATCH] cfq: Make use of service count to estimate the rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091126081409.GL8742@kernel.dk>
Date:	Thu, 26 Nov 2009 09:14:09 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	czoccolo@...il.com, Vivek Goyal <vgoyal@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cfq: Make use of service count to estimate the rb_key
	offset

On Thu, Nov 26 2009, Gui Jianfeng wrote:
> Hi Jens, Czoccolo
> 
> For the moment, different workload cfq queues are put into different
> service trees. But CFQ still uses "busy_queues" to estimate rb_key 
> offset when inserting a cfq queue into a service tree. I think this 
> isn't appropriate, and it should make use of service tree count to do 
> this estimation. This patch is for for-2.6.33 branch.

Makes sense, we've before discussed that using ->busy_queues isn't very
good, as it's not a stable count. service_tree count isn't that much
better, but for for-2.6.33 it does make more sense.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/