linux-kernel - Re: [PATCH] perf tools: Add _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B161F3D.3040202@windriver.com>
Date:	Wed, 02 Dec 2009 16:03:09 +0800
From:	Wang Liming <liming.wang@...driver.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Ingo Molnar <mingo@...e.hu>, mhiramat@...hat.com,
	fweisbec@...il.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]  perf tools: Add _GNU_SOURCE macro for strndup()

Xiao Guangrong wrote:
> 
> Liming Wang wrote:
>> strndup is a GNU extension. So add _GNU_SOURCE macro
>> to avoid compiling error.
>>
>> Signed-off-by: Liming Wang <liming.wang@...driver.com>
>> Acked-by: Frederic Weisbecker <fweisbec@...il.com>
>> ---
>>  tools/perf/util/string.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c
>> index 0977cf4..ea3eb39 100644
>> --- a/tools/perf/util/string.c
>> +++ b/tools/perf/util/string.c
>> @@ -1,5 +1,8 @@
>> +#define _GNU_SOURCE
>>  #include <string.h>
>>  #include <stdlib.h>
>> +
>> +#undef _GNU_SOURCE
> 
> I think those two "#include" can be removed,
> because util.h include it.
Agreed. It's a better method.

Liming Wang
> 
>>  #include "string.h"
>>  #include "util.h"
>>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/