linux-kernel - Re: [PATCH] checkpatch.pl skip long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Jun 2010 03:04:29 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Fredrik Gustafsson <iveqy@...qy.com>
Cc:	apw@...onical.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl skip long lines

On Sat, Jun 12, 2010 at 07:09:44PM +0200, Fredrik Gustafsson wrote:

> since the number of long lines in the linux kernel is huge and since
> Greg Kroah Hartman in his google tech talk about the kernel
> (http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably
> ignore that criteria in the future, I thought the checkpatch.pl script
> should have an option to ignore checking for long lines.
> 
> This would help finding the real errors and warnings, because they don't
> drown in line length warnings.

Instead of adding another command-line option, I'd suggest to just use CHK
instead of WARN, so this check will be enabled with --strict. I wonder if there
is already consensus on deprecating the 80-char-rule?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)