linux-kernel - Re: [PATCH 1/2] KVM: SVM: Check for nested vmrun intercept before emulating vmrun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100802203344.GO23755@8bytes.org>
Date:	Mon, 2 Aug 2010 22:33:44 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	Joerg Roedel <joerg.roedel@....com>,
	Marcelo Tosatti <mtosatti@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] KVM: SVM: Check for nested vmrun intercept before
	emulating vmrun

On Mon, Aug 02, 2010 at 06:18:09PM +0300, Avi Kivity wrote:
>  On 08/02/2010 05:46 PM, Joerg Roedel wrote:
>> This patch lets the nested vmrun fail if the L1 hypervisor
>> has not intercepted vmrun. This fixes the "vmrun intercept
>> check" unit test.
>
>> +
>>   static bool nested_svm_vmrun(struct vcpu_svm *svm)
>>   {
>>   	struct vmcb *nested_vmcb;
>> @@ -2029,6 +2037,17 @@ static bool nested_svm_vmrun(struct vcpu_svm *svm)
>>   	if (!nested_vmcb)
>>   		return false;
>>
>> +	if (!nested_vmcb_checks(nested_vmcb)) {
>> +		nested_vmcb->control.exit_code    = SVM_EXIT_ERR;
>> +		nested_vmcb->control.exit_code_hi = 0;
>> +		nested_vmcb->control.exit_info_1  = 0;
>> +		nested_vmcb->control.exit_info_2  = 0;
>> +
>> +		nested_svm_unmap(page);
>> +
>> +		return false;
>> +	}
>> +
>
> Don't you have to transfer an injected event to exitintinfo?

APM2 seems to be quiet about this. I just tried it out and event_inj
still contains the event after a failed vmrun on real hardware. This
makes sense because this is no real vmexit because the vm was never
entered.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/