linux-kernel - [PATCH -next] mfd: tps6586x depends on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100810094059.c320b916.randy.dunlap@oracle.com>
Date:	Tue, 10 Aug 2010 09:40:59 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH -next] mfd: tps6586x depends on GPIOLIB

From: Randy Dunlap <randy.dunlap@...cle.com>

tps6586x uses gpio interfaces, so it should depend on GPIOLIB.

Fixes these build errors:

drivers/mfd/tps6586x.c:41: error: field 'gpio' has incomplete type
drivers/mfd/tps6586x.c:195: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/tps6586x.c:195: warning: initialization from incompatible pointer type
drivers/mfd/tps6586x.c:210: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/tps6586x.c:210: warning: initialization from incompatible pointer type
drivers/mfd/tps6586x.c:219: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/tps6586x.c:219: warning: initialization from incompatible pointer type
drivers/mfd/tps6586x.c:249: error: implicit declaration of function 'gpiochip_add'

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Samuel Ortiz <sameo@...ux.intel.com>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100810.orig/drivers/mfd/Kconfig
+++ linux-next-20100810/drivers/mfd/Kconfig
@@ -543,7 +543,7 @@ config MFD_JZ4740_ADC
 
 config MFD_TPS6586X
 	tristate "TPS6586x Power Management chips"
-	depends on I2C
+	depends on I2C && GPIOLIB
 	select MFD_CORE
 	help
 	  If you say yes here you get support for the TPS6586X series of
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/