linux-kernel - Re: [PATCH] xconfig: Change the titlebar if using Qt3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C84D154.7070303@suse.cz>
Date:	Mon, 06 Sep 2010 13:32:36 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Alexander Stein <alexander.stein@...ormatik.tu-chemnitz.de>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xconfig: Change the titlebar if using Qt3

On 2.9.2010 18:52, Alexander Stein wrote:
> Hello Marek,
> 
> On Wednesday 01 September 2010 17:46:37 Michal Marek wrote:
>> Qt4 is now used by default and will get more testing. In case someone
>> still uses Qt3 and reports a bug, make it easy to recognize that this is
>> Qt3.
>>
>> Cc: Alexander Stein <alexander.stein@...ormatik.tu-chemnitz.de>
>> Signed-off-by: Michal Marek <mmarek@...e.cz>
>> ---
>>  scripts/kconfig/qconf.cc |   10 ++++++++--
>>  1 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
>> index 88d3874..a04e451 100644
>> --- a/scripts/kconfig/qconf.cc
>> +++ b/scripts/kconfig/qconf.cc
>> @@ -1274,8 +1274,14 @@ ConfigMainWindow::ConfigMainWindow(void)
>>  	char title[256];
>>
>>  	QDesktopWidget *d = configApp->desktop();
>> -	snprintf(title, sizeof(title), _("Linux Kernel v%s Configuration"),
>> -		getenv("KERNELVERSION"));
>> +	snprintf(title, sizeof(title), _("Linux Kernel v%s Configuration%s"),
>> +		getenv("KERNELVERSION"),
>> +#if QT_VERSION < 0x040000
>> +		" (Qt3)"
>> +#else
>> +		""
>> +#endif
>> +		);
>>  	setCaption(title);
>>
>>  	width = configSettings->readNumEntry("/window width", d->width() - 64);
> 
> Looks fine to me.

OK, I committed it with "Acked-by: <you>"

thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/