linux-kernel - Re: [PATCH 05/10] ovl: make sure fsync is never called on the lower filesystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1OsfJG-0005kR-Bl@pomaz-ex.szeredi.hu>
Date:	Mon, 06 Sep 2010 19:16:46 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	NeilBrown <neilb@...e.de>
CC:	miklos@...redi.hu, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] ovl: make sure fsync is never called on the lower
	filesystem.

On Mon, 06 Sep 2010, NeilBrown wrote:
> If we open a directory O_RDONLY, ->realfile could be on the lower
> filesystem.
> While fsync is not likely to be called on such a file, we should make
> sure never to pass the fsync down as we are treating the lower
> filesystem as read-only.

Why not?  fsync() works fine on an r/o filesystem.  It doesn't do
much, probably, but that's not a reason to add additional complexity.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/