lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Oct 2010 10:38:22 -0400 (EDT) From: Alan Stern <stern@...land.harvard.edu> To: Rahul Ruikar <rahul.ruikar@...il.com> cc: David Brownell <dbrownell@...rs.sourceforge.net>, Greg Kroah-Hartman <gregkh@...e.de>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] usb: gadget: dummy_hcd: Fix error path On Sat, 2 Oct 2010, Alan Stern wrote: > On Sat, 2 Oct 2010, Rahul Ruikar wrote: > > > In function dummy_udc_probe() > > call put_device() when device_register() fails. > > > > Signed-off-by: Rahul Ruikar <rahul.ruikar@...il.com> > > --- > > drivers/usb/gadget/dummy_hcd.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c > > index dc65462..2548091 100644 > > --- a/drivers/usb/gadget/dummy_hcd.c > > +++ b/drivers/usb/gadget/dummy_hcd.c > > @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev) > > dum->gadget.dev.parent = &pdev->dev; > > dum->gadget.dev.release = dummy_gadget_release; > > rc = device_register (&dum->gadget.dev); > > - if (rc < 0) > > + if (rc < 0) { > > + put_device(&dum->gadget.dev); > > return rc; > > + } > > > > usb_get_hcd (dummy_to_hcd (dum)); > > Acked-by: Alan Stern <stern@...land.harvard.edu> I take this back. The call usb_get_hcd needs to be moved up before the device_register (maybe to the start of the function.) Otherwise dummy_gadget_release would do an unbalanced usb_put_hcd. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists