linux-kernel - Re: [PATCH] usb: gadget: dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi==MpP6FpvqWtmHwDM7CCRbTAz-TMyLS_Z_thGj@mail.gmail.com>
Date:	Sat, 2 Oct 2010 20:16:51 +0530
From:	Rahul Ruikar <rahul.ruikar@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: dummy_hcd: Fix error path

On 2 October 2010 20:01, Alan Stern <stern@...land.harvard.edu> wrote:
> On Sat, 2 Oct 2010, Rahul Ruikar wrote:
>
>> In function dummy_udc_probe()
>> call put_device() when device_register() fails.
>>
>> Signed-off-by: Rahul Ruikar <rahul.ruikar@...il.com>
>> ---
>>  drivers/usb/gadget/dummy_hcd.c |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
>> index dc65462..2548091 100644
>> --- a/drivers/usb/gadget/dummy_hcd.c
>> +++ b/drivers/usb/gadget/dummy_hcd.c
>> @@ -885,8 +885,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
>>       dum->gadget.dev.parent = &pdev->dev;
>>       dum->gadget.dev.release = dummy_gadget_release;
>>       rc = device_register (&dum->gadget.dev);
>> -     if (rc < 0)
>> +     if (rc < 0) {
>> +             put_device(&dum->gadget.dev);
>>               return rc;
>> +     }
>>
>>       usb_get_hcd (dummy_to_hcd (dum));
>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
>
> Similar changes are needed in net2280.c, file_storage.c and
> f_mass_storage.c, probably also in goku_udc.c and langwell_udc.c.
> Would you like to make them?
>
yes Alan, I am aware of changes needed in these files. actually there
are many other changes needed for these files ( apart from
device_register() failure.. ) I am working on these files. also this
current patch need some updates.

Thanks,
Rahul

> Alan Stern
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/