linux-kernel - Re: [PATCH] Skip looking for ioapic overrides when ioapics are not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1k4m0lkla.fsf@fess.ebiederm.org>
Date:	Sat, 02 Oct 2010 07:45:21 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Avinash Kurup <kurup.avinash@...il.com>
Subject: Re: [PATCH] Skip looking for ioapic overrides when ioapics are not present

"H. Peter Anvin" <hpa@...or.com> writes:

> On 06/05/2010 08:56 PM, Eric W. Biederman wrote:
>> 
>> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
>> index 33f3563..226a6d1 100644
>> --- a/arch/x86/kernel/apic/io_apic.c
>> +++ b/arch/x86/kernel/apic/io_apic.c
>> @@ -4066,6 +4066,9 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity)
>>  {
>>  	int ioapic, pin, idx;
>>  
>> +	if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
>> +		return -1;
>> +
>>  	if (skip_ioapic_setup)
>>  		return -1;
>>  
>
> I was just poked about this patch... it doesn't build "make allnoconfig"
> on x86-64.
>
> This is also a bugzilla ticket now:
> https://bugzilla.kernel.org/show_bug.cgi?id=17772

That sucks.  Do we need to move this function into an acpi specific
file to pass allnonconfig?

Barring crazy build issues the fix is right.

I'm not certain when I will get a chance to look at build issues
as my load spiked considerably.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/