linux-kernel - Re: [PATCH] fs: return error on error condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101021091642.GD5329@cr0.nay.redhat.com>
Date:	Thu, 21 Oct 2010 17:16:42 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Jens Axboe <jaxboe@...ionio.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: return error on error condition

On Wed, Oct 20, 2010 at 04:50:47PM +0200, Nicolas Kaiser wrote:
>It's intended to return an error, right?
>
>Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
>---
> fs/pipe.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/fs/pipe.c b/fs/pipe.c
>index 279eef9..37eb1eb 100644
>--- a/fs/pipe.c
>+++ b/fs/pipe.c
>@@ -382,7 +382,7 @@ pipe_read(struct kiocb *iocb, const struct iovec *_iov,
> 			error = ops->confirm(pipe, buf);
> 			if (error) {
> 				if (!ret)
>-					error = ret;
>+					ret = error;
> 				break;
> 			}
> 

Wow, I think you are right. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/