linux-kernel - Re: [PATCH] fs: return error on error condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CC005F3.3080500@fusionio.com>
Date:	Thu, 21 Oct 2010 11:20:51 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Nicolas Kaiser <nikai@...ai.net>
CC:	Alexander Viro <viro@...iv.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: return error on error condition

On 2010-10-20 16:50, Nicolas Kaiser wrote:
> It's intended to return an error, right?
> 
> Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
> ---
>  fs/pipe.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/pipe.c b/fs/pipe.c
> index 279eef9..37eb1eb 100644
> --- a/fs/pipe.c
> +++ b/fs/pipe.c
> @@ -382,7 +382,7 @@ pipe_read(struct kiocb *iocb, const struct iovec *_iov,
>  			error = ops->confirm(pipe, buf);
>  			if (error) {
>  				if (!ret)
> -					error = ret;
> +					ret = error;
>  				break;
>  			}
>  

Thanks, that is indeed a bug. I'll commit and mark for stable.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/