linux-kernel - Re: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101209113416.66baf7ac@schatten.dmk.lab>
Date:	Thu, 9 Dec 2010 11:34:16 +0100
From:	Florian Mickler <florian@...kler.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Asbjoern Sloth Toennesen <asbjorn@...jorn.biz>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch
 errors

On Thu, 09 Dec 2010 03:32:28 +0000
Ben Hutchings <bhutchings@...arflare.com> wrote:

> On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> > Swap argument order in order to avoid checkpatch treating it as an
> > unary operation, instead of an binary one, and obtain consistency
> > with the 3 other similar assignments in netdev.c (tdlen & rdlen).
> > 
> > This patch fixes 3 checkpatch errors.
> 
> You have got to be kidding.  If the checkpatch warning offends you, fix
> the bug in checkpatch instead of changing perfectly good code.
> 
> Ben.

That bug is fixed already:
 https://patchwork.kernel.org/patch/299172/

Andrew picked it up.

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/