linux-kernel - Re: [patch 3/4] This patch introduces a new oprofile sample add function (oprofile_add_ext_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110104153411.GV4739@erda.amd.com>
Date:	Tue, 4 Jan 2011 16:34:11 +0100
From:	Robert Richter <robert.richter@....com>
To:	"graalfs@...ux.vnet.ibm.com" <graalfs@...ux.vnet.ibm.com>
CC:	"mingo@...e.hu" <mingo@...e.hu>,
	"oprofile-list@...ts.sf.net" <oprofile-list@...ts.sf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
	"borntraeger@...ibm.com" <borntraeger@...ibm.com>,
	"schwidefsky@...ibm.com" <schwidefsky@...ibm.com>,
	"heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
	Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
	Maran Pakkirisamy <maranp@...ux.vnet.ibm.com>
Subject: Re: [patch 3/4] This patch introduces a new oprofile sample add
 function (oprofile_add_ext_hw_sample)

On 20.12.10 08:05:44, graalfs@...ux.vnet.ibm.com wrote:
> From: graalfs@...ux.vnet.ibm.com
> 
> This patch introduces a new oprofile sample add function (oprofile_add_ext_hw_sample)
> that can also take task_struct as an argument, which is used by the hwsampler kernel module 
> when copying hardware samples to OProfile buffers.
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>
> Signed-off-by: Maran Pakkirisamy <maranp@...ux.vnet.ibm.com>
> Signed-off-by: Heinz Graalfs <graalfs@...ux.vnet.ibm.com>
> ---
>  drivers/oprofile/cpu_buffer.c |   26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)

> +void oprofile_add_ext_hw_sample(unsigned long pc, struct pt_regs * const regs,
> +				unsigned long event, int is_kernel,
> +				struct task_struct *task)
> +{
> +	__oprofile_add_ext_sample(pc, regs, event, is_kernel, task);
> +}
> +EXPORT_SYMBOL_GPL(oprofile_add_ext_hw_sample);

Hmm, I am not convinced of this new interface between the hwsampler
module and oprofile. It is asymmetric and bloats the function's
parameters list. A first simplification would be to not implement
hwsampler as module and integrate this in oprofile. Then, we can look
for a better way to add samples to the oprofile buffer. What do you
think?

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/