linux-kernel - Re: [GIT PULL] block driver updates for 2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikdULkbB83Us_zXivv8Y5FGdHrixUXRiitacaSh@mail.gmail.com>
Date:	Thu, 13 Jan 2011 16:02:12 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jens Axboe <jaxboe@...ionio.com>,
	Pekka Enberg <penberg@...nel.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Tejun Heo <tj@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] block driver updates for 2.6.38

On Thu, Jan 13, 2011 at 2:19 PM, Stephen Hemminger
<shemminger@...tta.com> wrote:
>
> It looks my floppy format problem wasn't my patch but the HPET-MSI
> problem. https://patchwork.kernel.org/patch/69588/
>
> Why hasn't that been fixed in mainline kernel?

Because the proper fix was _supposed_ to be the one that disabled MSI
for just the affected AMD boards. See

  commit 73472a46b5b28116b145fb5fc05242c1aa8e1461
  Author: Pallipadi, Venkatesh <venkatesh.pallipadi@...el.com>
  Date:   Thu Jan 21 11:09:52 2010 -0800

    x86: Disable HPET MSI on ATI SB700/SB800

    HPET MSI on platforms with ATI SB700/SB800 as they seem to have some
    side-effects on floppy DMA. Do not use HPET MSI on such platforms.

    Original problem report from Mark Hounschell
    http://lkml.indiana.edu/hypermail/linux/kernel/0912.2/01118.html

    [ This patch needs to go to stable as well. But, there are some
      conflicts that prevents the patch from going as is. I can
      rebase/resubmit to stable once the patch goes upstream.
      hpa: still Cc:'ing stable@ as an FYI. ]

    Tested-by: Mark Hounschell <markh@...pro.net>
    Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
    Cc: <stable@...nel.org>
    LKML-Reference: <20100121190952.GA32523@...ux-os.sc.intel.com>
    Signed-off-by: H. Peter Anvin <hpa@...or.com>

and if you have the same problem (MSI + floppy doesn't work), can you
give more information about your system?

In particular, is it an AMD southbridge that we don't have listed?
Right now we only trigger it for machines that match this:

  PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS

(which is PCI device 1002:4385) and it may be that we have incomplete coverage.

And so few people use floppies (and expect them to work), that we
probably have very bad test coverage too.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/