linux-kernel - Re: [RFC] checkpatch: add option to change warning return value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110323184346.GA5947@xanatos>
Date:	Wed, 23 Mar 2011 11:43:46 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org,
	James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [RFC] checkpatch: add option to change warning return value.

On Wed, Mar 23, 2011 at 11:07:07AM +0100, Johannes Weiner wrote:
> On Tue, Mar 22, 2011 at 04:13:10PM -0700, Sarah Sharp wrote:
> > There are a lot of warnings in checkpatch.pl that are rather subjective.
> > For instance, when a line is 81 characters long, and the patch submitter
> > is just cleaning up existing code, a maintainer may not care that
> > checkpatch.pl warns about the over 80-character line.  It should be up to
> > the maintainer what warnings they want to pay attention to.
> > 
> > Unfortunately, if you try to run checkpatch.pl as part of a git pre-commit
> > hook and a patch in a series being applied by git-am fails checkpatch.pl,
> > the whole process stops.  At that point I usually end up just disabling
> > that git hook, which means I don't see real errors in the patches.
> > 
> > Add an option to checkpatch.pl to print the warnings, but not return an
> > error code when the --lazy flag is present.  (Anyone with a better name
> > can pipe up, lazy just seemed to be the opposite to strict.)  This allows
> > the maintainer to view the warnings, but still allow the patch application
> > process to continue.
> 
> I first thought you would add code that allowed turning only select
> errors into warnings.
> 
> If you just want to have git continue in any case, why not append
> '|| true' to the line that invokes checkpatch in your hook script?

Because I still want to stop the patch application process if a true
error was found.  I just don't want to stop the patch application
process if just a warning was found.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/