linux-kernel - Re: [PATCH] timers: consider slack value in mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110524121343.GA17312@Chamillionaire.breakpoint.cc>
Date:	Tue, 24 May 2011 14:13:43 +0200
From:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] timers: consider slack value in mod_timer()

* Yong Zhang | 2011-05-24 15:54:17 [+0800]:

>> diff --git a/kernel/timer.c b/kernel/timer.c
>> index fd61986..bf09726 100644
>> --- a/kernel/timer.c
>> +++ b/kernel/timer.c
>> @@ -804,6 +804,8 @@ int mod_timer(struct timer_list *timer, unsigned long expires)
>> ?? ?? ?? ?? ?? ?? ?? ??return 1;
>>
>> ?? ?? ?? ??expires = apply_slack(timer, expires);
>
>So, why not move above line up, then we can use the recalculated
>expires?

We leave often before apply_slack() kicks in. From printks() it looks
like we leave more often in first "return 1" than in the second. Moving
that line up would lead to more __mode_timer() calls.

>
>Thanks,
>Yong

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/