linux-kernel - Re: [PATCH 2/3] kprobes/trace: Fix kprobe selftest for gcc 4.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DEE6C82.4000901@caviumnetworks.com>
Date:	Tue, 07 Jun 2011 11:22:58 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	David Daney <ddaney.cavm@...il.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH 2/3] kprobes/trace: Fix kprobe selftest for gcc 4.6

On 06/07/2011 11:12 AM, Steven Rostedt wrote:
> On Tue, 2011-06-07 at 11:08 -0700, David Daney wrote:
>
>>> -static int kprobe_trace_selftest_target(int a1, int a2, int a3,
>>> -					int a4, int a5, int a6)
>>> +/*
>>> + * Can't be static, otherwise gcc might optimize this to
>>> + * not be in the kallsyms table.
>>> + */
>>
>> Could you make it '__used' instead?
>>
>
> I can try, but the problem is not that the function itself is being
> optimized out. It looks like its being turned into anonymous text. That
> is, it optimized out the symbol name, not the code itself.
>

Really it is no big deal either way.  Just a thought I had.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/