linux-kernel - Re: RFC: Use dynamic-debug with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxyNBxs0hcTV=0N1UBYWnuXKsMUq3DC3GDgedRL5YX+34A@mail.gmail.com>
Date:	Wed, 10 Aug 2011 23:44:46 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jason Baron <jbaron@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-i2c@...r.kernel.org
Subject: Re: RFC: Use dynamic-debug with pr_debug when -DDEBUG is set

On Wed, Aug 10, 2011 at 7:03 PM, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2011-08-10 at 20:20 -0400, Jason Baron wrote:
>> On Wed, Aug 10, 2011 at 05:01:37PM -0700, Joe Perches wrote:
>> > Perhaps another way to enable pr_debug use
>> > is to reverse the order of dynamic_pr_debug
>> > defines.
>> > ie:  change printk.h:
>> > #if defined(CONFIG_DYNAMIC_DEBUG)
>> > /* dynamic_pr_debug() uses pr_fmt() internally so we don't need it here */
>> > #define pr_debug(fmt, ...) \
>> >     dynamic_pr_debug(fmt, ##__VA_ARGS__)
>> > #elif defined(DEBUG)
>> > #define pr_debug(fmt, ...) \
>> >     printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>> > and change dynamic_debug.h:
>> > #define DPRINTK_FLAGS_DEFAULT 0
>> > to:
>> > #if defined DEBUG
>> > #define DPRINTK_FLAGS_DEFAULT DPRINTK_FLAGS_PRINT
>> > #else
>> > #define DPRINT_FLAGS_DEFAULT 0
>> > #endif
>> > That seems pretty sensible to me.  Jason?
>> cool idea. I like it.
>
> You've got a bunch of patches ready to
> be pulled/queued, so I think you should
> do it.
>
> cheers, Joe
>

Thanks Joe,

Ive just added this.  It works nicely, with one trivial change
to add MODNAME, imitating the common non-dynamic-debug usage:

#if defined DEBUG
#define _DPRINTK_FLAGS_DEFAULT _DPRINTK_FLAGS_PRINT |
_DPRINTK_FLAGS_INCL_MODNAME

Ive tested the changes on scx200_acb, and changed
the printks therein to corresponding pr_<foo>
As I said, it works nicely.

Ive added these 2 patches to my series, which I'll be posting shortly.
In the meantime, its available at:

git://github.com/jimc/linux-2.6.git
in branch dyndbg-v4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/