linux-kernel - Re: [patch 3/8] iommu: move IOMMU specific code to intel-iommu.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110825170534.GL1923@amd.com>
Date:	Thu, 25 Aug 2011 19:05:34 +0200
From:	"Roedel, Joerg" <Joerg.Roedel@....com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
CC:	"mingo@...e.hu" <mingo@...e.hu>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"yinghai@...nel.org" <yinghai@...nel.org>,
	"Song, Youquan" <youquan.song@...el.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [patch 3/8] iommu: move IOMMU specific code to intel-iommu.c

On Wed, Aug 24, 2011 at 02:31:40PM -0400, Suresh Siddha wrote:
> On Wed, 2011-08-24 at 02:27 -0700, Roedel, Joerg wrote:
> > On Tue, Aug 23, 2011 at 08:05:20PM -0400, Suresh Siddha wrote:
> > > +static void __init dmar_register_rmrr_unit(struct dmar_rmrr_unit *rmrr)
> > > +int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header)
> > > +int __init dmar_parse_one_atsr(struct acpi_dmar_header *hdr)
> > > +int dmar_find_matched_atsr_unit(struct pci_dev *dev)
> > > +int dmar_parse_rmrr_atsr_dev(void)
> > 
> > If these functions are not DMAR specific, how about replacing the dmar_
> > prefix too while at it?
> 
> These parsing functions are APCI DMAR table specific and are used only
> by intel-iommu routines. Because of this I didn't change their names but
> just moved to intel-iommu.c to cleanup some of the ifdef's in the common
> dmar.c code (specific to handling common ACPI DMAR tables etc) shared by
> both DMA-remapping (iommu) and IRQ-remapping.

Okay, should be fine then.

Thanks,

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/