linux-kernel - Re: [PATCH 2/2] mm: Add comment explaining task state setting in bdi_forker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110907151936.1d67c706.akpm@linux-foundation.org>
Date:	Wed, 7 Sep 2011 15:19:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mm: Add comment explaining task state setting in
 bdi_forker_thread()

On Mon, 5 Sep 2011 17:53:47 +0200
Jan Kara <jack@...e.cz> wrote:

> On Mon 05-09-11 20:44:11, Wu Fengguang wrote:
> > On Mon, Sep 05, 2011 at 06:01:41PM +0800, Jan Kara wrote:
> > > On Sun 04-09-11 11:05:51, Wu Fengguang wrote:
> > > > > @@ -401,6 +401,13 @@ static int bdi_forker_thread(void *ptr)
> > > > >  		}
> > > > >  
> > > > >  		spin_lock_bh(&bdi_lock);
> > > > > +		/*
> > > > > +		 * In the following loop we are going to check whether we have
> > > > > +		 * some work to do without any synchronization with tasks
> > > > > +		 * waking us up to do work for them. So we have to set task
> > > > > +		 * state already here so that we don't miss wakeups coming
> > > > 
> > > > s/already/early/ ?
> > >   Thanks for review. We'd have to substitute 'already here' with 'early'
> > > for the sentence to make make sense. But frankly I don't see why one would
> > > be better than the other one...
> > 
> > You are the native English speaker?  OK, I have no more problems... ;)
>   No, I'm not a native English speaker. Maybe that's why I don't see that
> much difference :-))

grammar can often be fixed/improved by deleting stuff ;)

--- a/mm/backing-dev.c~mm-add-comment-explaining-task-state-setting-in-bdi_forker_thread-fix
+++ a/mm/backing-dev.c
@@ -404,9 +404,8 @@ static int bdi_forker_thread(void *ptr)
 		/*
 		 * In the following loop we are going to check whether we have
 		 * some work to do without any synchronization with tasks
-		 * waking us up to do work for them. So we have to set task
-		 * state already here so that we don't miss wakeups coming
-		 * after we verify some condition.
+		 * waking us up to do work for them. Set the task state here
+		 * so that we don't miss wakeups after verifying conditions.
 		 */
 		set_current_state(TASK_INTERRUPTIBLE);
 
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/