linux-kernel - Re: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110922162953.GA31282@kroah.com>
Date:	Thu, 22 Sep 2011 09:29:53 -0700
From:	Greg KH <greg@...ah.com>
To:	Oren Weil <oren.jer.weil@...el.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	tomas.winkler@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.

On Wed, Sep 21, 2011 at 04:45:31PM +0300, Oren Weil wrote:
> Acked-by: Tomas Winkler <tomas.winkler@...el.com>
> Signed-off-by: Oren Weil <oren.jer.weil@...el.com>
> ---
>  drivers/staging/mei/TODO |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/mei/TODO b/drivers/staging/mei/TODO
> index 3b6a667..7d9a13b 100644
> --- a/drivers/staging/mei/TODO
> +++ b/drivers/staging/mei/TODO
> @@ -1,14 +1,4 @@
>  TODO:
> -	- Create in-kernel Client API. Examples of in-kernel clients are watchdog and AMTHI.

Did you really do this?

> -	- ME Watchdog Driver to expose standard Linux watchdog interface

And this?

> -	- Rewrite AMTHI to use in-kernel client interface

And this?

> -	- Cleanup init and probe functions
> -	- Review BUG/BUG_ON usage
> -	- Cleanup and reorganize header files
> -	- Rewrite client data structure

And this?

> -	- Make state machine more readable
> -	- Add mei.txt with driver explanation and it's driver

You really don't describe the kernel/user api here, that needs to be
well documented as it is a ABI you are creating and we need to know how
it works.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/