linux-kernel - RE: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Sep 2011 21:12:21 +0300
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <greg@...ah.com>,
	"Weil, Oren jer" <oren.jer.weil@...el.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.



> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Thursday, September 22, 2011 7:30 PM
> To: Weil, Oren jer
> Cc: gregkh@...e.de; devel@...verdev.osuosl.org; Winkler, Tomas; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.
> 
> On Wed, Sep 21, 2011 at 04:45:31PM +0300, Oren Weil wrote:
> > Acked-by: Tomas Winkler <tomas.winkler@...el.com>
> > Signed-off-by: Oren Weil <oren.jer.weil@...el.com>
> > ---
> >  drivers/staging/mei/TODO |   10 ----------
> >  1 files changed, 0 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/mei/TODO b/drivers/staging/mei/TODO index
> > 3b6a667..7d9a13b 100644
> > --- a/drivers/staging/mei/TODO
> > +++ b/drivers/staging/mei/TODO
> > @@ -1,14 +1,4 @@
> >  TODO:
> > -	- Create in-kernel Client API. Examples of in-kernel clients are
> watchdog and AMTHI.
> 
> Did you really do this?
We came to conclusion, this is not really necessary.
> 
> > -	- ME Watchdog Driver to expose standard Linux watchdog interface

Yes, this was submitted in the previous batch and it doesn't required really decupling as we previously estimated.
 
> And this?
> 
> > -	- Rewrite AMTHI to use in-kernel client interface
> 
> And this?
This would be only use case for creating API and in this case it would just bloat the driver for little benefit.

Since this le
> 
> > -	- Cleanup init and probe functions
> > -	- Review BUG/BUG_ON usage
> > -	- Cleanup and reorganize header files
> > -	- Rewrite client data structure
> 
> And this?

This was mostly done, you can judge if this is enough.

> 
> > -	- Make state machine more readable
> > -	- Add mei.txt with driver explanation and it's driver
> 
> You really don't describe the kernel/user api here, that needs to be well
> documented as it is a ABI you are creating and we need to know how it
> works.

The API is described in the mei.txt that is present in the driver folder. There was also lengthy discussion about it 
In LKML during our first try to submit the driver. If it is still not clear enough please let us know we would happy to fix it 
as any other gaps.

Thanks
Tomas
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/