linux-kernel - Re: [Kgdb-bugreport] [PATCH v2 3/3] param: make /sys/module/*/paramaters optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Nov 2011 08:21:30 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Tim Bird <tim.bird@...sony.com>,
	Jason Wessel <jason.wessel@...driver.com>
Cc:	David Decotigny <david.decotigny@...gle.com>,
	Kroah-Hartman <gregkh@...e.de>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	"Richard\@mail2.fw-bc.sony.com" <Richard@...l2.fw-bc.sony.com>,
	"linux-doc\@vger.kernel.org" <linux-doc@...r.kernel.org>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	"kgdb-bugreport\@lists.sourceforge.net" 
	<kgdb-bugreport@...ts.sourceforge.net>,
	Dmitry Torokhov <dtor@...are.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Schmidt <mschmidt@...hat.com>,
	"David\@mail2.fw-bc.sony.com" <David@...l2.fw-bc.sony.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	"Greg\@mail2.fw-bc.sony.com" <Greg@...l2.fw-bc.sony.com>,
	Satoru Moriya <satoru.moriya@....com>,
	Sievers <kay.sievers@...y.org>, Decotigny <decot@...gle.com>,
	"Kay\@mail2.fw-bc.sony.com" <Kay@...l2.fw-bc.sony.com>,
	Kennedy <richard@....demon.co.uk>
Subject: Re: [Kgdb-bugreport] [PATCH v2 3/3] param: make /sys/module/*/paramaters optional

On Wed, 2 Nov 2011 09:24:35 -0700, Tim Bird <tim.bird@...sony.com> wrote:
> On 11/2/2011 6:30 AM, Jason Wessel wrote:
> > On 11/01/2011 06:50 PM, David Decotigny wrote:
> I would also like to see the size numbers.  However, to address
> Jason's concern, I think it's safe to assume that when someone is
> getting this aggressive with system size, they'll start leaving debug
> features on the floor (printk, kdb, etc.).  What would be appropriate,
> IMHO, would be to add a config dependency for kgdb/kdb and
> NOT resurrect /proc items.  There's work in progress in linux-tiny
> to tackle /proc configurability, and adding back /proc interfaces
> is likely to just have the issue resurface there.
>   -- Tim

This is already CONFIG_EXPERT; I don't think anyone really wants to turn
this off.

Yes, I think the patch comes from a false premise: that the reason that
people don't expost module params in sysfs is due to memory usage, and
that providing a way to turn that off will alleviate their fears.

So, my advice to David: just change the perms on any and all module
parameters you want.  *Then* if someone complains about bloat, you can
re-submit these patches and cc: me.

(BTW, don't like the first patch: static is nice, but keeping related
code together is nicer).

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/