linux-kernel - Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 Nov 2011 18:03:53 +0900
From:	Tomoya MORINAGA <tomoya-linux@....lapis-semi.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Takashi Iwai <tiwai@...e.de>
CC:	perex@...ex.cz, linux-kernel@...r.kernel.org,
	"Wang, Qi" <qi.wang@...el.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	"Clark, Joel" <joel.clark@...el.com>,
	"Ewe, Kok Howg" <kok.howg.ewe@...el.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH

(2011/10/24 21:20), Mark Brown wrote:
> On Mon, Oct 24, 2011 at 09:12:42PM +0900, Tomoya MORINAGA wrote:
>
>> 1. PCI interface function.
>> Any current ASoC drivers don't have PCI interface function.
>> So I don't know where the function should be in machine driver or
>> platform driver.
>
> It depends on what the driver is for.  Probably you want a driver which
> is some combination of machine driver and the various drivers that are
> normally part of the SoC - whatever roles in the system are filled by
> this hardware the driver ought to register subsystem drivers for those
> roles.
>
>> 2. Register Access
>> Can platform driver access register ?
>> According to the soc document, platform driver must not access hardware,
>> however, some drivers looks accessing their hardware.
>
> What makes you say this?  A driver that can't access hardware would be
> rather useless...
>
>

Though roughly, we re-created 3 files codec driver, platform drive and 
machine driver. (Not debugged/tested)
Could you check these files ?

(1)codec driver
    ml26124.c ml26124.h

(2)platform driver
    ml7213ioh-plat.c ml7213ioh-plat.h ioh_i2s_config.h ioh_i2s.h

(3)machine driver
    ml7213ioh-machine.c

Thanks in advance.

-- 
tomoya
ROHM Co., Ltd.

View attachment "ml26124.c" of type "text/plain" (19969 bytes)

View attachment "ioh_i2s.h" of type "text/plain" (3428 bytes)

View attachment "ioh_i2s_config.h" of type "text/plain" (64670 bytes)

View attachment "ml7213ioh-machine.c" of type "text/plain" (2280 bytes)

View attachment "ml7213ioh-plat.c" of type "text/plain" (66728 bytes)

View attachment "ml7213ioh-plat.h" of type "text/plain" (6184 bytes)

View attachment "ml26124.h" of type "text/plain" (4579 bytes)