linux-kernel - Re: bug of gpio transition in pinmux driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Nov 2011 01:25:38 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: bug of gpio transition in pinmux driver

On Thu, Nov 24, 2011 at 1:13 AM, Stephen Warren <swarren@...dia.com> wrote:
> Haojian Zhuang wrote at Wednesday, November 23, 2011 6:13 AM:
>> Hi Linus & Stephen,
>>
>> There's a bug in pinmux driver. We can request gpio via
>> pinmux_request_gpio(@gpio). @gpio is the gpio number.
>>
>> In pinmux_request_gpio():
>>     pin = @gpio - range->base;
>>     pin_request(pin);
>>
>> This pin is the index of pinctrl_pin_desc[]. What's the definition of
>> pinctrl_pin_desc's index? It's the index of PAD, not GPIO. Since the
>> goal of pinmux_request_gpio() is to avoid define too much gpio groups.
>> We need to add the transition between gpio and pad. It's clear that
>> the transition of "pin = @gpio - range->base" can't fit every silicon.
>
>> Especially, one gpio can be routed to two pads in PXA silicon.
>
> That particular case isn't really covered yet; we've been discussing how
> to solve that case; see:
>
> https://lkml.org/lkml/2011/11/21/370
>
> --
> nvpublic
>
>

Thanks a lot for your quick reply. If you could cc linux-arm-kernel
mailist for the later discussion of pinmux, it would be better.

Best Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/