linux-kernel - Re: [PATCH] nohz: Remove update_ts_time_stat from tick_nohz_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111202004513.GA15880@somewhere.redhat.com>
Date:	Fri, 2 Dec 2011 01:45:17 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	linux-kernel@...r.kernel.org,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] nohz: Remove update_ts_time_stat from
 tick_nohz_start_idle

On Thu, Dec 01, 2011 at 05:00:22PM +0100, Michal Hocko wrote:
> There is no reason to call update_ts_time_stat from tick_nohz_start_idle
> anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field)
> when we updated idle_lastupdate unconditionally.
> 
> We haven't set idle_active yet and do not provide last_update_time so
> the whole call end up being just 2 wasted branches.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.cz>
> CC: Arjan van de Ven <arjan@...ux.intel.com>
> CC: Thomas Gleixner <tglx@...utronix.de>

Reviewed-by Frederic Weisbecker <fweisbec@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/