linux-kernel - Re: [PATCH] vmalloc: remove #ifdef in function body

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111221060739.GD28505@barrios-laptop.redhat.com>
Date:	Wed, 21 Dec 2011 15:07:39 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmalloc: remove #ifdef in function body

On Tue, Dec 20, 2011 at 09:58:19PM -0800, Joe Perches wrote:
> On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote:
> > On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote:
> > > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote:
> > > > We don't like function body which include #ifdef.
> []
> > > I don't like this change.
> > > I think it's perfectly good style to use:
> > I feel it's no problem as it is because it's very short function now
> > but it's not style we prefer. 
> 
> Who is this "we" you refer to?
> 
> There's nothing suggesting your patch as a preferred style
> in Documentation/CodingStyle.

Yes. It doesn't have. 
But I have thought we have done until now.
I think we can see them easily.

#> grep -nRH 'static inline void' ./ | grep {} | wc -l
936

If we consider line which don't include brace in one line, it would be many.

> 
> cheers, Joe
> 

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/