linux-kernel - Re: kconfig: tristate choice with depender choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120218.001405.229654364.anemo@mba.ocn.ne.jp>
Date:	Sat, 18 Feb 2012 00:14:05 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	lacombar@...il.com
Cc:	mmarek@...e.cz, sam@...nborg.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: kconfig: tristate choice with depender choice

On Thu, 09 Feb 2012 23:30:17 +0900 (JST), Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
> I tested in this way:
> 
> 1. Add this example to the end of drivers/char/Kconfig file.
> -------------------------------------
> choice
> 	prompt "choice list AB"
> config A
> 	tristate "a"
> config B
> 	tristate "b"
> endchoice
> choice
> 	prompt "choice list CD"
> 	depends on A
> config C
>        	bool "c"
> config D
>        	bool "d"
> endchoice
> -------------------------------------
> 
> 2. Then run commands:
> 
> $ cp arch/x86/configs/i386_defconfig arch/x86/configs/test_defconfig
> $ echo 'CONFIG_A=y' >> arch/x86/configs/test_defconfig 
> $ make O=../build test_defconfig
> $ grep CONFIG_A= ../build/.config
> CONFIG_A=m

I did some investigations.
When this happens, sym_calc_value() was called recursively.

main
  conf_set_all_new_symbols
    sym_calc_value ("choice list CD")
      sym_calc_visibility ("choice list CD")
        expr_calc_value
          sym_calc_value ("A")

On this place in sym_calc_value(), sym->def[S_DEF_USER].tri was 'yes'
and sym->visible was 'mod'.

		newval.tri = EXPR_AND(sym->def[S_DEF_USER].tri,
				      sym->visible);
		goto calc_newval;

Then new value of CONFIG_A will be 'mod'.

I suppose sym->visible is 'mod' because default value of tristate
choice is 'mod'.  Is this correct?
Any suggestions for fixing or debugging?

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/