linux-kernel - Re: [PATCH 0/3] Replace bmp085 with bmp18x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201202292018.45557.arnd@arndb.de>
Date:	Wed, 29 Feb 2012 20:18:45 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Eric Andersson <eric.andersson@...xphere.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	christoph.mair@...il.com, stefan.nilsson@...xphere.com,
	zhengguang.guo@...ch-sensortec.com, peter.moeller@...bosch.com,
	Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH 0/3] Replace bmp085 with bmp18x

On Wednesday 29 February 2012, Eric Andersson wrote:
> This patch-set replaces the BMP085 driver with a driver for Bosch Sensortec's new
> generation of pressure sensors called BMP18x. These pressure sensors can be
> connected on I2C but also on SPI as a variant, so the driver implements both.
> Register-wise they are fully compatible with the older BMP085, so the driver will
> support those chips as well.
> 
> The driver is based on bmp085.c by Christoph Mair.

Hmm,  the implementation looks fine, but I don't think we should add support
for new devices with a one-off interface that we know is getting replaced by
something generic.

Why is this not using IIO for its user interface?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/