| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Mar 2012 12:15:18 +0000 From: Chris Wilson <chris@...is-wilson.co.uk> To: Daniel Kurtz <djkurtz@...omium.org>, Keith Packard <keithp@...thp.com>, David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Cc: Benson Leung <bleung@...omium.org>, Yufeng Shen <miletus@...omium.org>, Sameer Nanda <snanda@...omium.org>, Daniel Kurtz <djkurtz@...omium.org> Subject: Re: [PATCH 3/9] drm/i915/intel_i2c: refactor using intel_gmbus_get_bus On Wed, 7 Mar 2012 19:50:44 +0800, Daniel Kurtz <djkurtz@...omium.org> wrote: > Instead of letting other modules directly access the ->gmbus array, > introduce a new API, intel_gmbus_get_bus(), to lookup an i2c_adapter for > a given gmbus pin pair identifier. This API enables later refactoring > of the gmbus pin pair list. > > Note: It is critical that intel_setup_gmbus() gets called before > intel_gmbus_get_bus(). If you are going to rename it, perhaps a better choice than intel_gmbus_get_bus(int gpio_pin) ? intel_i2c_get_adapter(int gpio_pin) since the rest of the code really does not care how the bits are transferred but that it interfaces using i2c. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists