linux-kernel - Re: [vmw_vmci RFC 01/11] Apply VMCI context code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120516100121.3be6d0ca@nehalam.linuxnetplumber.net>
Date:	Wed, 16 May 2012 10:01:21 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Andrew Stiegmann (stieg)" <astiegmann@...are.com>
Cc:	linux-kernel@...r.kernel.org, acking@...are.com, dtor@...are.com,
	gregkh@...uxfoundation.org,
	virtualization@...ts.linux-foundation.org, dsouders@...are.com,
	akpm@...ux-foundation.org, cschamp@...are.com
Subject: Re: [vmw_vmci RFC 01/11] Apply VMCI context code

On Tue, 15 May 2012 08:06:58 -0700
"Andrew Stiegmann (stieg)" <astiegmann@...are.com> wrote:

> Context code maintains state for vmci and allows the driver
> to communicate with multiple VMs.
> 
> Signed-off-by: Andrew Stiegmann (stieg) <astiegmann@...are.com>

Running checkpatch reveals the usual noise, and the following that
should be addressed.

ERROR: do not use C99 // comments
#272: FILE: drivers/misc/vmw_vmci/vmci_context.c:183:
+static bool ctx_exists_locked(uint32_t cid)	// IN

ERROR: "foo * bar" should be "foo *bar"
#304: FILE: drivers/misc/vmw_vmci/vmci_context.c:215:
+		      uid_t * user, struct vmci_ctx **outContext)

I don't mind the C99 style comments, but the // IN convention
is pretty useless and should be removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/