linux-kernel - Re: [PATCH 3/3][RFC] x86: x2apic/cluster: Do not handle cpumask allocation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1337645958.1997.172.camel@sbsiddha-desk.sc.intel.com>
Date:	Mon, 21 May 2012 17:19:18 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH 3/3][RFC] x86: x2apic/cluster: Do not handle cpumask
 allocation errors

On Fri, 2012-05-18 at 12:26 +0200, Alexander Gordeev wrote:
> With this fix allocations of cpumasks are assumed always successfull
> and possible failures result in BUG().

BUG check for memory allocation failures in IPI path is not a good idea.
We will be using IPI's to flush TLB's before we evict the pages for
recovering from low-memory conditions.  We need to provide a clean fall
back path.

So NAK.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/