linux-kernel - Re: [PATCH 13/24] TTY: um/line, use tty from tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FCCD44A.3090500@nod.at>
Date:	Mon, 04 Jun 2012 17:29:14 +0200
From:	Richard Weinberger <richard@....at>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	Jiri Slaby <jirislaby@...il.com>, gregkh@...uxfoundation.org,
	alan@...ux.intel.com, linux-kernel@...r.kernel.org,
	Jeff Dike <jdike@...toit.com>,
	user-mode-linux-devel@...ts.sourceforge.net,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 13/24] TTY: um/line, use tty from tty_port

Hi!

Am 04.06.2012 17:20, schrieb Jiri Slaby:
> On 06/04/2012 02:01 PM, Richard Weinberger wrote:
>> I have two questions: 1. Are these patches also usable on 3.4 and
>> 3.3 or do they depend on 3.5's TTY changes?
> 
> Hi, I don't think they depend on any changes.

Nice.

>> 2. Why didn't you use tty_port_open()/close()/etc. as Alan
>> suggested my in [1]?
> 
> This was not intended to fix anything particular. If it does, it is a
> pure coincidence... These patches are a minimalistic subset to ensure
> every driver has its own tty_port for each tty. We will need this
> pairing later.

It looks like that it solves UML's TTY issues with systemd distros. :-)

> So the switch of the driver to the new tty port API, as suggested by
> Alan, is still needed. I might do that later if I learn how to make
> UML work. (The conversion is by definition invasive and needs runtime
> testing.)

Two days ago I did so but still faced the problems described here:
https://lkml.org/lkml/2012/3/10/163

Thanks,
//richard


Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)