linux-kernel - Re: [PATCH] docs: block: update ioprio.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG27Bk1_q+fBvG49TO1TjwwALVjwhNoEWTOaiiUJt65=-3+7Kg@mail.gmail.com>
Date:	Thu, 21 Jun 2012 08:50:25 +0200
From:	Sami Kerola <kerolasa@....fi>
To:	Rob Landley <rob@...dley.net>
Cc:	Jens Axboe <axboe@...nel.dk>,
	Bernhard Voelker <mail@...nhard-voelker.de>,
	Zheng Liu <wenqing.lz@...bao.com>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, util-linux@...r.kernel.org
Subject: Re: [PATCH] docs: block: update ioprio.txt

On Thu, Jun 21, 2012 at 6:50 AM, Rob Landley <rob@...dley.net> wrote:
> On 06/19/2012 05:27 AM, Zheng Liu wrote:
>> Hi Sami,
>>
>> [You forgot to CC'd other developers and mailing list]

Some times I do that intentionally. Oh, well now when my opinion is public...

>> On Tue, Jun 19, 2012 at 10:54:41AM +0200, Sami Kerola wrote:
>>> Hi Zheng,
>>>
>>> Wouldn't a patch such as below be better?
>>
>> Looks good to me.  But, IMHO, if reader cannot access Internet, my patch
>> maybe is better for them.  The original writer is not me.  So I don't
>> understand the original idea that puts ionice source code in here.  I
>> think that Jens can do the final decision.
>>
>> Hi Jens,
>>
>> What's your opintion about Sami's and my patch?
>
> I note that it's nice to have a reference implementation for nontrivial
> things. Also, util-linux isn't the end-all and be-all of linux
> userspace: busybox has an ionice, and I plan to add an ionice
> implementation to toybox as well.
>
> So fixing reference code is good. That said, this isn't a "fix", this is
> a rewrite adding all sorts of unnecessary complexity
> (internationalization? strtos32_or_error() instead of strtol()?) that
> makes it much _less_ effective as reference code.

That makes sense. How about having simple example in linux
Documentation/ and note with reference link to util-linux
implementation. The note could tell something like 'version various
distributions package comes from util-linux, please see [git link]'.

-- 
   Sami Kerola
   http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/