linux-kernel - Re: linux-next: Tree for Jun 20 (hweight return type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2012 11:45:46 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Namjae Jeon <linkinjeon@...il.com>
Subject: Re: linux-next: Tree for Jun 20 (hweight return type)

On Wed, 20 Jun 2012 18:10:09 -0700 Randy Dunlap <rdunlap@...otime.net> wrote:
>
> Someone changes the return type of __const_hweight8() to
> (unsigned long).  That causes printk format warnings when
> hweight8/16() etc. is passed a constant:

That would be "include/linux/bitops.h: fix warning" from the akpm tree
(adding cc's).

> 
> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
> drivers/input/joystick/analog.c:416:5: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
> 
> 
> Note that in
> 
> #define hweight8(w)  (__builtin_constant_p(w) ? __const_hweight8(w)  : __arch_hweight8(w))
> 
> __arch_hweight*() still returns unsigned int while __const_hweight*()
> returns unsigned long.  This can't be good, can it?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped