linux-kernel - Re: [PATCH] perf tools: Fix an error on perf-bench document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMO-S2j74+=9QJ40-=3Zj9a2M2wnCC474vsm216GP-BB9OWbsg@mail.gmail.com>
Date:	Wed, 27 Jun 2012 23:28:22 +0900
From:	Hitoshi Mitake <h.mitake@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: Fix an error on perf-bench document

On Mon, Jun 25, 2012 at 12:59 AM, Hitoshi Mitake <h.mitake@...il.com> wrote:
> On Tue, Jun 19, 2012 at 5:48 PM, Namhyung Kim <namhyung@...nel.org> wrote:
>> Hi, Ingo
>>
>> On Mon, 18 Jun 2012 11:05:01 +0200, Ingo Molnar wrote:
>>> There's several typos all across the perf bench documentation:
>>>
>>> 1)
>>>
>>>        This perf bench command is general framework for benchmark suites.
>>>
>>> s/is general/is a general
>>>
>>
>> Will fix.
>>
>>
>>> 2)
>>>
>>> The output of 'perf bench --help' outputs weird looking
>>> formatting characters like:
>>>
>>>            .ft C
>>>            % perf bench sched pipe                      # with no style specified
>>>            (executing 1000000 pipe operations between two tasks)
>>>                    Total time:5.855 sec
>>>                            5.855061 usecs/op
>>>                            170792 ops/sec
>>>            .ft
>>>
>>
>> I have no idea on this, maybe a problem of asciidoc?
>>
>>
>>> 3)
>>>
>>> This:
>>>
>>>            all: test all suite (pseudo suite)
>>>
>>> s/all suite (psudo suite)/all benchmark suites
>>>
>>> (this should be fixed for perf bench mem as well.)
>>>
>>
>> Will fix.
>>
>>
>>> 4)
>>>
>>> perf bench mem memcpy -h outputs:
>>>
>>>     -l, --length <1MB>    Specify length of memory to copy. available unit: B, MB, GB (upper and lower)
>>>
>>> bad capitalization: s/. a/. A
>>>
>>> s/unit/units
>>>
>>
>> Will fix too.
>>
>>
>>> 5)
>>>
>>> This:
>>>
>>>     -c, --clock           Use CPU clock for measuring
>>>
>>> should probably clarify why the CPU clock matters and what
>>> measurement is done otherwise.
>>>
>>
>> This looks a bit weird. If -c switch was given, it'd use the cycles
>> event not the cpu-clock event. If omitted, it'd use the gtod().
>>
>
> Very sorry, I misused the terms clock and cycles. The memset uses
> hardware cycles event, the above naming and description with "clock"
> is very bad...
> I will write and send a patch for fix the problem.

I wrote the simple fix for eliminatng wrong usage of "clock":
https://github.com/mitake/linux/commit/b7836d41deff430c16058ca729120dccfa41e74e

This patch assumes the change made by the Namhyung's patch. So I'm
planning to send this after the Namhyung's patch is applied to tip
tree. Or should the patches be unified before applied?


-- 
Hitoshi Mitake
h.mitake@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/