| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Jun 2012 12:32:00 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Zoltan Kelemen <zoltan.kelemen@...isec.se> Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org, willy@...a-x.org Subject: Re: [PATCH 1/3] staging:panel: Rewrite for fixing synchronization issues On Fri, Jun 29, 2012 at 11:05:16AM +0200, Zoltan Kelemen wrote: > On 29 jun 2012 09:24 "Dan Carpenter" <dan.carpenter@...cle.com> wrote: > > > Gar... Don't do this. :/ Each bullet point here should be a > > separate patch. Please break it apart and resend. > > I understand a large patch is harder to audit than small incremental changes, but the patch was the result of a code rewrite, where I attempted to summarize the changes in large in the bulleted list. There isn't a one-to-one correspondence between a bullet and a change in the code. Breaking the rewrite into small pieces would not only be quite hard but to some extent even more confusing to audit since you risk to see the leaves instead of the tree. > We've done this before. We can help you break it apart. Step 1: Change all the existing spinlocks to spin_lock_bh(). Step 2: Do all the white space changes. Step 3: Shuffle the global variable declarations around. That's half the patch gone already. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists