linux-kernel - Re: [PATCH 5/5] mfd: tps6586x: remove gpio support from core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ-zsBKSwyzecOpsWyM0o6-EYQwrqWopzeQm1D0D6TaEg@mail.gmail.com>
Date:	Sun, 15 Jul 2012 00:12:49 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	grant.likely@...retlab.ca, linus.walleij@...ricsson.com,
	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	swarren@...dia.com, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 5/5] mfd: tps6586x: remove gpio support from core driver

On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:

> The GPIO functionality of device tps6586x is added through
> platform gpio driver and it can be register as the mfd sub
> device and hence removing the duplicates code which register
> the gpio functionality from core driver.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

The only thing I worry about is if old defconfig files are now
missing this config option and then this patch becomes an
unbisectable showstopper for them because they don't get
this driver by default anymore.

So please make sure you've grepped around and checked
that of some platforms defconfig was previously selecting
the core driver, make sure it selects this driver too for
the moment, it's better if they later deactivate it
if they don't need it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/