| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdadrHaH0kCfn22T+GnO=TKNvexcup+TsajPgnQgkiQ9Gw@mail.gmail.com> Date: Sun, 15 Jul 2012 00:18:05 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Laxman Dewangan <ldewangan@...dia.com> Cc: grant.likely@...retlab.ca, linus.walleij@...ricsson.com, sameo@...ux.intel.com, linux-kernel@...r.kernel.org, swarren@...dia.com, broonie@...nsource.wolfsonmicro.com Subject: Re: [PATCH 4/5] gpio: tps6586x: add gpio support through platform driver On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan <ldewangan@...dia.com> wrote: > Converting the gpio driver of tps6586x to a platform > driver in place of registering the gpio through core > driver. > The motivation of the change is: > - This is inline with the mfd drivers implementation. > - This will move the related gpio support to gpio driver > folder where all gpio related drivers are available. > This will be easy the maintenance and enhancement is > anything done for gpio. > - The gpio functionality can be selected through config > variable. > > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com> Overall this is very, very good and you're doing the right thing. > --- /dev/null > +++ b/drivers/gpio/gpio-tps6586x.c > +#include <linux/i2c.h> Why? Reviewed-by: Linus Walleij <linus.walleij@...aro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists