linux-kernel - Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <501FFD23.9080109@linaro.org>
Date:	Mon, 06 Aug 2012 10:21:39 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	tglx@...utronix.de, a.p.zijlstra@...llo.nl,
	richardcochran@...il.com, prarit@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust()

On 08/04/2012 12:21 PM, Ingo Molnar wrote:
> * Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> wrote:
>
>> Hello.
>>
>> Bisected to 2a8c0883 "time: Move xtime_nsec adjustment
>> underflow handling timekeeping_adjust".
>>
>> Would you check?
> probably caused by this stray return in timekeeping_adjust():
>
>          } else
>                  return;
>
> which should really be a proper goto - like the (totally
> untested!) patch below.

Ooof.   Your analysis looks correct, thanks for fixing this, Ingo!
And thanks for catching the issue Tetsuo!

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/